Wednesday, July 15, 2009

No respect

I have no respect for people who write code like this example below:

if(this.hasActionMessages()){
return false;
}else{
return true;
}

2 comments:

vpapanik said...

You mean the wrong indentation don't you ? :D :D :D

Francis Devereux said...

if(this.hasActionMessages() == BooleanConstants.FALSE){
return false;
}else if (this.hasActionMessages() == BooleanConstants.TRUE) {
return true;
} else {
throw new IllegalArgumentException("Unknown value returned by hasActionMessages()");
}
Much better ;-)